• update to v3.3.0: https://github.com/asmaloney/libE57Format/releases/tag/v3.3.0
• add nix-update-script
• remove CXXFLAGS override, shouldn't be necessary anymore (at least in my testing)
• instead of fetching submodules, manually link in our gtest sources in prePatch (reduces source archive size)
• fix bash error if dontDisableStatic is undefined
• move xercesc to propagatedBuildInputs (see below)

Note: I am a bit puzzled by the postInstall script. I'm not quite sure retaining hybrid static-and-shared builds is worth the effort, especially since the installed CMake target definition only knows about the static library, so the shared library will be ignored by CMake consumers. I'd be in favor of removing it and only building shared libraries, but perhaps there's something I'm missing. The installed target file for reference:

#----------------------------------------------------------------
# Generated CMake target import file for configuration "Release".
#----------------------------------------------------------------

# Commands may need to know the format version.
set(CMAKE_IMPORT_FILE_VERSION 1)

# Import target "E57Format" for configuration "Release"
set_property(TARGET E57Format APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE)
set_target_properties(E57Format PROPERTIES
  IMPORTED_LINK_INTERFACE_LANGUAGES_RELEASE "CXX"
  IMPORTED_LOCATION_RELEASE "/nix/store/x6wwf4x4c5fcbirnmkvlpgkam93ilr96-libe57format-3.3.0/lib/libE57Format.a"
  )

list(APPEND _cmake_import_check_targets E57Format )
list(APPEND _cmake_import_check_files_for_E57Format "/nix/store/x6wwf4x4c5fcbirnmkvlpgkam93ilr96-libe57format-3.3.0/lib/libE57Format.a" )

# Commands beyond this point should not need to know the version.
set(CMAKE_IMPORT_FILE_VERSION)

Move xercesc to propagatedBuildInputs

libe57format refers to xercesc in its exported CMake package configuration file, which in turn means it is required by every package which has libe57format in its buildInputs (only pdal at the moment). Therefore, xercesc should be part of propagatedBuildInputs.

This also simplifies the new AliceVision PR I put together, see #496867.

Reference

In the generated package config file (/nix/store/.../lib/cmake/E57Format/e57format-config.cmake), XercesC is required via find_dependency.

include(CMakeFindDependencyMacro)

find_dependency(XercesC REQUIRED)
include(${CMAKE_CURRENT_LIST_DIR}/E57Format-export.cmake)

set_target_properties(E57Format PROPERTIES
    MAP_IMPORTED_CONFIG_MINSIZEREL "MinSizeRel;Release"
    MAP_IMPORTED_CONFIG_RELWITHDEBINFO "RelWithDebInfo;Release"
)

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.